Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][DO NOT MERGE] Add GuessByRegexp. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hanabokuro
Copy link
Contributor

This is an experimental implementation.

@syucream
Copy link
Owner

GuessByRegexp looks useful guess rule! I'd like to support that but we need to think how to read regexp pattern string.

We can some options, like below:

  • cli options
    • It's a simple way, but giving complicated regexp's become hard.
    • I'm imaging to give a regexp-specific option name, like -regexp-pattern=... to indicate it's relating to regexp rule explicitly.
  • config file
    • It helps us to write complicated regexp pattern.
    • But hakagi need handling to read the files. (It's a little problem?)
  • environment variable
    • It's similar to cli options.

I recommend we try the config file way because it looks flexible and an additional cost is only reading files. What do you think? Is it acceptable? 🤔

@hanabokuro
Copy link
Contributor Author

I think that cost is acceptable.
I will try to write a code that handle config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants