Justified Text Across Whole App #423

ashu-dadhich · 2017-03-10T10:01:37Z

PR for issue #337.
Summary
Used bluejamesbond/TextJustify-Android(https://github.com/bluejamesbond/TextJustify-Android) in order to justify text across whole app.

Changes:

Moved Redundant Code to JustificationUtil.
Corrected naming conventions in both java and xml code.

Issue Video link(youtube):

Safety Tools(https://youtu.be/KA5AWdLj9Jo)
Get Help Now(https://youtu.be/iHdZwxbO7lg)
Sexual Assault Awareness(https://youtu.be/zkLop-Tw9P8)
Policies(https://youtu.be/D1Q3D3sv9Gw)
Support Services(https://youtu.be/Vix-rxlAPaY)

ashu-dadhich · 2017-04-05T15:20:27Z

@sandarumk please review.
Thank you

chamika · 2017-04-11T18:44:19Z

app/src/main/AndroidManifest.xml

            android:label="@string/user_settings_activity"
            android:parentActivityName=".MainActivity"
-            android:windowSoftInputMode="adjustPan|stateAlwaysHidden"
-            android:configChanges="orientation|screenSize">


Did you remove configChanges?

I apologise if I misunderstood something but I think the config changes are there. I just reformatted the code of "AndroidManifest" since it was not aligned properly.

chamika · 2017-04-11T18:48:55Z

...src/main/java/com/peacecorps/pcsa/safety_tools/FormattedSafetyPlanBasicsContentFragment.java

+ * Created by ashu on 5/2/17.
+ */
+
+public class FormattedSafetyPlanBasicsContentFragment extends DialogFragment {


No need to create a formatted fragment. Is there any dependency for not changing the original fragment?

chamika · 2017-04-11T18:52:03Z

app/src/main/java/com/peacecorps/pcsa/safety_tools/ScreenSlideCustomPagerAdapter.java

+
+    public DocumentView addDocumentView(CharSequence article, int type, boolean rtl) {
+        final DocumentView documentView = new DocumentView(mContext, type);
+        documentView.getDocumentLayoutParams().setTextColor(mContext.getResources().getColor(R.color.primary_text_default_material_dark));


Can't you use JustificationUtil

Thank you for telling me about it will correct this by tomorrow.

chamika · 2017-04-11T18:52:20Z

app/src/main/java/com/peacecorps/pcsa/support_services/StepsFragment.java

+
+    public DocumentView addDocumentView(CharSequence article, int type, boolean rtl) {
+        final DocumentView documentView = new DocumentView(getActivity(), type);
+        documentView.getDocumentLayoutParams().setTextColor(getResources().getColor(R.color.primary_text_default_material_dark));


Can't you use JustificationUtil

Will correct it by tomorrow.

chamika · 2017-04-11T18:53:39Z

app/src/main/java/com/peacecorps/pcsa/sexual_assault_awareness/HelpingFragment.java

+                true, new RelativeSizeSpan(1f), new JustifiedSpan());
+        DocumentView reporting_step1 = util.addDocumentView(Html.toHtml(articleBuilder1),
+                DocumentView.FORMATTED_TEXT, false, getActivity());
+        reporting_step1.getDocumentLayoutParams().setTextAlignment(TextAlignment.JUSTIFIED);


So many code duplicates here. Move the common part to a single method

Same reason as StepsFragment.java

chamika · 2017-04-11T18:54:32Z

app/src/main/java/com/peacecorps/pcsa/support_services/StepsFragment.java

+        View rootView = inflater.inflate(R.layout.fragment_reporting_steps, container, false);
+        ((AppCompatActivity) getActivity()).getSupportActionBar().setTitle(R.string.after_assault);
+
+        ArticleBuilder articleBuilder1 = new ArticleBuilder();


Remove code duplicates

I apologise for that but I was forced to do that since in this library it is required to create new instance of every-time we are justifying a new block of text in the same screen.

chamika · 2017-04-11T18:55:16Z

app/src/main/res/layout/fragment_formatted_safety_plan_basics_content.xml

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="utf-8"?>


If possible update the original one instead of creating new one

ashu-dadhich · 2017-04-11T20:48:23Z

@chamika the library has a slight problem since it been made over scroll view. It treats both the formatted(bold/hyperlinked etx) and plain text in the same. i.e. when we try to justify the formatted text it is justified but its formatting goes away.

So after numerous trail and errors and contacting with its maintainer I found out that in order to make the formatted text justified I had to do it programmatically using article builder instead of the conventional method i.e. using XML.

Reason for creating new layouts instead of creating new ones?
Some portions of the app share the same xml layout. But as I have mentioned before the formatted and the plain text needed to be treated differently. Thats why a formatted variant of the layout was created so that it could be used to justify formatted text.

Why not change the library?
Because this gives more control over the justified text and due to this word spacing remains uniform which is not the case with other libraries.

AND

thank you for reviewing it!

ashu-dadhich · 2017-04-13T16:01:06Z

@sandarumk @chamika changes done.
Changes:

now the javaUtil function supports all three adapter/activity/fragment classes.

Please review.
Thank you

ashu-dadhich · 2017-05-02T15:45:49Z

@sandarumk is this PR approved? if not what other changes do I have to do please tell.

sandarumk · 2017-08-30T03:18:24Z

@top-gun007 can you have a look at Codecy errors and fix them as well?

ashu-dadhich · 2017-08-31T13:05:25Z

will fix them @sandarumk

sandarumk requested review from Buddhiprabha and removed request for Buddhiprabha April 11, 2017 18:36

chamika reviewed Apr 11, 2017

View reviewed changes

ashu-dadhich force-pushed the just_final branch from 4df5db6 to c27f169 Compare April 12, 2017 17:16

justificationSuggestedChangesDone

8ccd4b8

ashu-dadhich force-pushed the just_final branch from fc487cf to 8ccd4b8 Compare April 13, 2017 15:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Justified Text Across Whole App #423

Justified Text Across Whole App #423

ashu-dadhich commented Mar 10, 2017

ashu-dadhich commented Apr 5, 2017 •

edited

Loading

chamika Apr 11, 2017 •

edited

Loading

ashu-dadhich Apr 11, 2017

chamika Apr 11, 2017

chamika Apr 11, 2017

ashu-dadhich Apr 11, 2017

chamika Apr 11, 2017

ashu-dadhich Apr 11, 2017

chamika Apr 11, 2017

ashu-dadhich Apr 11, 2017

chamika Apr 11, 2017

ashu-dadhich Apr 11, 2017

chamika Apr 11, 2017

ashu-dadhich commented Apr 11, 2017 •

edited

Loading

ashu-dadhich commented Apr 13, 2017 •

edited

Loading

ashu-dadhich commented May 2, 2017

sandarumk commented Aug 30, 2017

ashu-dadhich commented Aug 31, 2017

Justified Text Across Whole App #423

Are you sure you want to change the base?

Justified Text Across Whole App #423

Conversation

ashu-dadhich commented Mar 10, 2017

ashu-dadhich commented Apr 5, 2017 • edited Loading

chamika Apr 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashu-dadhich commented Apr 11, 2017 • edited Loading

ashu-dadhich commented Apr 13, 2017 • edited Loading

ashu-dadhich commented May 2, 2017

sandarumk commented Aug 30, 2017

ashu-dadhich commented Aug 31, 2017

ashu-dadhich commented Apr 5, 2017 •

edited

Loading

chamika Apr 11, 2017 •

edited

Loading

ashu-dadhich commented Apr 11, 2017 •

edited

Loading

ashu-dadhich commented Apr 13, 2017 •

edited

Loading