use centos as the base image #2
Conversation
JayjeetAtGithub
force-pushed
the
centos-base
branch
from
be79167
to
05c8590
Compare
| # pip install --upgrade pip | ||
| # pip install --upgrade virtualenv | ||
| scl enable devtoolset-8 bash | ||
| scl enable devtoolset-7 bash |
There was a problem hiding this comment.
all these packages should be installed already by the install-deps.sh, can you expand on why you needed to install these?
There was a problem hiding this comment.
It happend that these images were not installed by themselves and errored out due to their unavailabilty. So i installed them explicitly
There was a problem hiding this comment.
so then we need to fix install-deps.sh. That script is taken from the upstream Ceph repo, so we need to figure out the root cause, otherwise we won't be able to explain any subsequent failure
There was a problem hiding this comment.
what I meant is that this script as a whole shouldn't be needed.
There was a problem hiding this comment.
Oh I see. Yeah thats the ideal. So, what should be done now ? Should we try to fix in the upstream or continue with patches like this ? Patching will be error prone though
There was a problem hiding this comment.
we need to remove this script. Building the image should work without it. If there's a problem when building the ceph-builder image after we remove this script, then it'll very likely be something on our end. The upstream script is used extensively by the ceph community, and has some minor tweaks for skyhook (install arrow/parquet). It could still be something on the upstream script, but it's unlikely
| apt-get install -y git gnupg2 ccache && \ | ||
| ADD . / | ||
|
|
||
| RUN ./install-preq.sh && \ | ||
| git clone --branch $GIT_REF --depth 1 $GIT_URL ceph && \ | ||
| cd ceph && \ | ||
| ./install-deps.sh && \ | ||
| sh -c 'if [ -n "$EXTRA_PKGS" ]; then apt-get install -y "$EXTRA_PKGS"; fi' && \ |
There was a problem hiding this comment.
for centos, apt-get cannot run. So we can remove this line
Please ignore the changes in
.travis.ymlandwf.yml. Those are because of the substitutions bug in popper.