Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

fixed sourcemaps tests #565

Merged
merged 1 commit into from
Apr 24, 2016
Merged

fixed sourcemaps tests #565

merged 1 commit into from
Apr 24, 2016

Conversation

asapach
Copy link
Member

@asapach asapach commented Apr 24, 2016

One test is still failing ('sourceMapContents'), so it's being skipped.

@guybedford guybedford merged commit 641f59d into systemjs:master Apr 24, 2016
@guybedford
Copy link
Member

Amazing work, thank you! I take it this rules out this sourcemaps file for the source maps issues?

@asapach
Copy link
Member Author

asapach commented Apr 24, 2016

I'm sorry, could you please rephrase the question?

@guybedford
Copy link
Member

We're currently investigating a few source maps related issues in #542 and jspm/jspm-cli#1729. I thought one of those was why you were looking into this!

@asapach
Copy link
Member Author

asapach commented Apr 24, 2016

No, I'm still trying to figure out #297, so I'm starting with the tests.
I have indeed noticed some offset issues after traceur compliation, but I'm haven't dug into this.

@guybedford
Copy link
Member

I managed to fix this by working around Traceur in ae5a649. Traceur bug posted in google/traceur-compiler#2109.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants