-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add test for applying with 10 open change sets #4684
Conversation
65db30f
to
9946ebb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge this it'll run on all CI runs automatically and likely slow the API tests run down.
Might be worth putting it in a different folder or add a variant for a single execution in this tests folder to increase the coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tuned the test down to 10 change sets and made sure it cleans up after itself. The runs looks to be sub-minute now. That cool? https://github.com/systeminit/si/actions/runs/11018151975
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
b0da3ad
to
7c140da
Compare
7c140da
to
f705e6f
Compare
f705e6f
to
001206c
Compare
001206c
to
fd14f2d
Compare
All of these test workspaces now have the test asset installed.
pop
one of the change sets off and apply it