Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test for applying with 10 open change sets #4684

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

sprutton1
Copy link
Contributor

@sprutton1 sprutton1 commented Sep 24, 2024

All of these test workspaces now have the test asset installed.

  1. ensure the HEAD has 0 components by deleting them all and applying
  2. create 10 change sets and create one of the test components
  3. pop one of the change sets off and apply it
  4. walk all of the remaining change sets, ensure they now have two components on the graph, and abandon them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge this it'll run on all CI runs automatically and likely slow the API tests run down.

Might be worth putting it in a different folder or add a variant for a single execution in this tests folder to increase the coverage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tuned the test down to 10 change sets and made sure it cleans up after itself. The runs looks to be sub-minute now. That cool? https://github.com/systeminit/si/actions/runs/11018151975

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@sprutton1 sprutton1 force-pushed the apply_test branch 2 times, most recently from b0da3ad to 7c140da Compare September 24, 2024 16:15
@sprutton1 sprutton1 changed the title feat: add test for applying with 100 open change sets feat: add test for applying with 10 open change sets Sep 24, 2024
@sprutton1 sprutton1 added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 444e2ec Sep 24, 2024
15 checks passed
@sprutton1 sprutton1 deleted the apply_test branch September 24, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants