Merge pull request #677 from cldellow/oob-read-publishgroup

SortedNodeStore::publishGroup: out of bounds read
systemed · Feb 10, 2024 · 9cad4f5 · 9cad4f5
2 parents c630400 + 491ef83
commit 9cad4f5
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/sorted_node_store.cpp b/src/sorted_node_store.cpp
@@ -423,9 +423,11 @@ void SortedNodeStore::publishGroup(const std::vector<element_t>& nodes) {
 			lastChunk = currentChunk;
 		}
 
-		tmpLatpLons[currentNodeIndex] = nodes[i].second.latp;
-		tmpLatpLons[currentNodeIndex + 256] = nodes[i].second.lon;
-		currentNodeIndex++;
+		if (i != nodes.size()) {
+			tmpLatpLons[currentNodeIndex] = nodes[i].second.latp;
+			tmpLatpLons[currentNodeIndex + 256] = nodes[i].second.lon;
+			currentNodeIndex++;
+		}
 	}
 
 	uint64_t chunks = currentChunkIndex;