Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pang14: Specs, overviews, repairs #233

Merged
merged 1 commit into from
Jan 29, 2024
Merged

pang14: Specs, overviews, repairs #233

merged 1 commit into from
Jan 29, 2024

Conversation

jacobgkau
Copy link
Member

This adds the Pangolin 14 (pang14) to tech docs.

We've been adding an increasing number of part/model numbers to the descriptions at the start of each section on the repairs page. For this model, I've tried separating those numbers out into their own place in the description to make it more organized.

@jacobgkau jacobgkau requested review from a team January 27, 2024 01:38
@ahoneybun
Copy link
Member

For some reason the main list is not updated but the side list is?

Screenshot from 2024-01-29 07-37-08

@jacobgkau
Copy link
Member Author

@ahoneybun The lists aren't connected in any way, I just forgot to update the homepage list. (It usually goes that way since the sidebar list needs to be updated for the pages to render at all.) Fixed now.

Copy link
Member

@ahoneybun ahoneybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I just think it is the CPU gen.

src/models/pang14/README.md Outdated Show resolved Hide resolved
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One correction, but otherwise looks great! I like the addition of the part numbers in the repairs page.

src/models/pang14/README.md Outdated Show resolved Hide resolved
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacobgkau jacobgkau dismissed ahoneybun’s stale review January 29, 2024 20:07

Review points have been addressed

@jacobgkau jacobgkau merged commit a084cff into master Jan 29, 2024
1 check passed
@jacobgkau jacobgkau deleted the pang14 branch January 29, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants