Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch 3 (launch_3) #229

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Launch 3 (launch_3) #229

merged 1 commit into from
Jan 16, 2024

Conversation

jacobgkau
Copy link
Member

This adds the Launch 3 (launch_3) to tech docs.

@jacobgkau jacobgkau requested review from a team January 13, 2024 00:44
@jacobgkau
Copy link
Member Author

jacobgkau commented Jan 13, 2024

@leviport I noticed we have the height of launch_2 in the tech docs as 3.061cm, but the launch_3 sales page currently says 30.6mm. Do you know if there was actually a change in height, or if we just decided to drop the last digit of specificity due to manufacturing tolerances not being tight enough to justify including it?

@leviport
Copy link
Member

There were no dimension changes. Rounding off a thousandth of a millimeter seems fine, but keeping it to match launch_2 also doesn't seem objectionable. I'm good either way, up to you.

Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I didn't see any issues.

@jacobgkau jacobgkau merged commit 5f6cbee into master Jan 16, 2024
1 check passed
@jacobgkau jacobgkau deleted the launch branch January 16, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants