-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap backplane with board to match production and build #227
Conversation
I believe both terms are correct for that component. What makes you say that "board" is more correct than "backplane"? |
Production says backplane is incorrect and board is correct, like Thelio Io board. |
This README is obviously out of date, but the old Io board was said to "provide a SATA backplane" here: https://github.com/system76/thelio-io-hardware/blob/master/README.md?plain=1#L5 Since this PCB has the SATA functionality broken out into a standalone component, calling this a "SATA backplane" does not seem incorrect to me. Was there another reason for this change? |
The only reason is that both Production and Build call it SATA board and when backplane is mentioned they do not know what the part is. This is to get everyone on the same page about the component name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @s-mcnees this naming comes from the vendor who makes the product and SATA board is used for ordering the product as well. If there are any other issues with this change please reach out to her. |
This is our product, we decide the name, not a vendor. |
"Board" is a generic word that describes a PCB, so referring to the component as a board does not mean it's the name of the product. A Lemur Pro is a Lemur Pro, but it is often referred to as a "laptop" or a "computer" or a "machine." Thelio Io is frequently referred to as an "Io board," but that's not its name. I don't think this change is necessary, and I don't think "SATA backplane" was causing any confusion for readers. |
Per an internal discussion, the official name of the part is SATA Backplane, so I'm going to close this PR. |
This PR swaps backplane for board to correct name of the component.