Swap predicates for updateable optional values in 'ensure' and 'validation' #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the tests as well. |
|
ah these tests weren't caught by building |
FintanH
approved these changes
Mar 26, 2019
| validate e p a = | ||
| if p a then _Success # a else _Failure # e | ||
| validate :: Validate v => e -> (a -> Maybe b) -> a -> v e b | ||
| validate e p a = case p a of |
There was a problem hiding this comment.
Why not maybe (_Failure # b) ((#) _Success) . p? Just out of interest, I'm only a tourist in this repo 😊
There was a problem hiding this comment.
I did think about this variation first, but I decided against it because it doesn't bring much to the code. It doesn't pass my personal golfing threshold of "is this more elegant than a pattern match?", and it also wasn't idiomatic when compared to the rest of the code.
There was a problem hiding this comment.
That's fair! I'd go for a birdie and write maybe (_Failure # e) (\b -> _Success # b) . p but this version is also readable and elegant 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion here: #32
Also, found some unused imports