Skip to content

Fix query digests for comments for certain query sizes - Closes #4918. #4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

JavierJF
Copy link
Collaborator

@JavierJF JavierJF commented May 1, 2025

Closes #4918.

This patches has been tested using the AFL++ tests with the following clean results:

[AFL++ 81ffae2edf4f] /src/test/afl_digest_test # afl-whatsup -s output/
/usr/local/bin/afl-whatsup status check tool for afl-fuzz by Michal Zalewski

Summary stats
=============

        Fuzzers alive : 5
          Starting up : 1 (excluded from stats)
       Total run time : 1 days, 6 hours
          Total execs : 1374 millions
     Cumulative speed : 62007 execs/sec
  Total average speed : 12401 execs/sec
Current average speed : 59955 execs/sec
        Pending items : 0 faves, 0 total
   Pending per fuzzer : 0 faves, 0 total (on average)
     Coverage reached : 1.30%
        Crashes saved : 0
          Hangs saved : 0
 Cycles without finds : 37/312/73/76/65
   Time without finds : 28 minutes, 44 seconds

Removed unnecessary boundary check for certain comments.
…length'

Due to a typo/confusion, the boundary being used for comments check was
'd_max_len' instead of 'q_len'. This prevented the correct detection of
a comment start when the query exceeded 'query_digests_max_query_length'
which determines the value for 'd_max_len'.
- New regression payloads for fix in 5c3a063.
- Added config option for 'null' replacement in 'mz' payloads.
- When specifying 'regular' as command line option, it's now possible to
  also specify the path to the file holding the payloads to be tested.
@renecannao renecannao merged commit d622fcf into v3.0 May 8, 2025
30 of 163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid query digests generated for certain comments
2 participants