Support Resource Configuration #20
Conversation
src/main/scala/no/sysco/middleware/kafka/event/collector/cluster/BrokerManager.scala
Show resolved
Hide resolved
src/main/scala/no/sysco/middleware/kafka/event/collector/cluster/BrokerManager.scala
Show resolved
Hide resolved
src/main/scala/no/sysco/middleware/kafka/event/collector/cluster/BrokerManager.scala
Show resolved
Hide resolved
| @@ -15,11 +15,14 @@ import scala.concurrent.duration._ | |||
|
|
|||
| trait JsonSupport extends SprayJsonSupport with DefaultJsonProtocol { | |||
There was a problem hiding this comment.
Can be sealed because uses only in this class
There was a problem hiding this comment.
I would rather recommend change name from JsonSupport to smth else close to project naming convention (CollectorJsonProtocol) to differ from Spray library.
| @@ -89,7 +96,7 @@ class TopicManager( | |||
| */ | |||
| def handleTopicsCollected(topicsCollected: TopicsCollected): Unit = { | |||
| log.info(s"Handling ${topicsCollected.names.size} topics collected.") | |||
There was a problem hiding this comment.
Change to log.info(s"Handling {} topics collected.", topicsCollected.names.size)
src/main/scala/no/sysco/middleware/kafka/event/collector/cluster/BrokerManager.scala
Outdated
Show resolved
Hide resolved
| var topicsAndDescription: Map[String, Option[TopicDescription]] = Map() | ||
| var topics: Map[String, Option[Topic]] = Map() | ||
|
|
||
| implicit val timeout: Timeout = 5 seconds |
There was a problem hiding this comment.
Could u add to javadoc info about timeout and why 5 secs? It is implicit value, so it used somewhere here in class (I guess its time out for Future completion).
| manager ! TopicEvent("topic-1", TopicEvent.Event.TopicCreated(TopicCreated())) | ||
| manager ! TopicEvent("topic-2", TopicEvent.Event.TopicCreated(TopicCreated())) | ||
| manager ! TopicEvent("topic-3", TopicEvent.Event.TopicCreated(TopicCreated())) | ||
|
|
||
| // describe 2 internal |
There was a problem hiding this comment.
Dont forget also comments :) As I see now, U describe 2 NON-internal topic
| manager ! TopicDescribed(("topic-2", TopicDescription(internal = true, List.empty))) | ||
| manager ! TopicDescribed(("topic-2", TopicDescription(internal = false, List.empty))) | ||
| eventRepositoryProbe.expectMsg(DescribeConfig(ResourceType.Topic, "topic-2")) | ||
| eventRepositoryProbe.reply(Config()) | ||
| eventProducerProbe.expectMsgType[TopicEvent] | ||
| // describe 1 NOT internal |
There was a problem hiding this comment.
And opposite here U describe 1 INTERNAL topic
jeqo
changed the title
Entities like Topics and Brokers have additional configuration exposed via
AdminClient#describeConfigsAPI.The goal of this PR is to add support for these configuration as part of the events collected.
This will break compatibility with version 0.1, then once merged a new release 0.2 will be started.