-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI from Travis to GitHub Actions #172
base: master
Are you sure you want to change the base?
Conversation
Tests don't pass on version 4+ because django.conf.urls.url() is removed
on: | ||
push: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workflows added from a fork don't run by default (for security reasons) but you can check the results on my fork: https://github.com/browniebroke/snapshottest/actions
You probably want to disable CI on pushes to non-master branch before merging:
on: | |
push: | |
pull_request: | |
on: | |
push: | |
branches: | |
- master | |
pull_request: |
FYI @paulmelnikow, should help with maintainability 😄 |
The CI on Travis isn't running anymore, I tried to replicate the existing setup as much as possible in GitHub actions.
In the process, I realised that the supported versions are quite out of date, and more work will bed needed to bring the project up to date, but I consider this to be a separate piece of work, out of scope of what I'm trying to achieve here. I tried to minimise the amount of code changes.
Things to note:
from django.conf.urls import url
, which has been removed. I decided to restrict the Django version to <4 to minimise code changes.