Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make promise thread safety #70

Closed
wants to merge 4 commits into from
Closed

Make promise thread safety #70

wants to merge 4 commits into from

Conversation

Arfey
Copy link

@Arfey Arfey commented Apr 3, 2019

Hi guys 🤚.
I had a problem with dataloader when I running my application in thread mode. Problem was connected with async_instance because share this variable between threads. About that also described here:

#57 (comment)

This pull request solve current problem, but it's not perfect.
If u have some other better ideas how to fix that, so tell please and i'll try to do that.
This a big bug for me 😔 and i hope we solve that very quickly .
@syrusakbary

@jnak
Copy link
Contributor

jnak commented Dec 6, 2019

@Arfey Can you weigh in on this #80? It accomplishes the same goal but is more lightweight.

This pull request solve current problem, but it's not perfect.

Can you elaborate on what you mean here?

@Arfey
Copy link
Author

Arfey commented Dec 6, 2019

Yes, it looks like solution of my problem. I need some time to test this on my project.

@syrusakbary
Copy link
Owner

This should be solved by #81. Closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants