Fix issue with setting config via CLI #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where certain config settings, ie
exporter.years_of_historydon't work when set via the command line args.I think we've seen a few times and have put fixes on various branches: d10d07e , d0e4371#diff-a6b8b70e408cd3e34b8db02476445bfd607cad475dd9e80a5b62bc82c583b3b2
This is still a bandage though and we'll probably run into this again, but it should work as a quick fix. The longer andmore permanent fix would be to keep separate variables for the things the cli args can set, and only instantiate the 2 Options objects after all args have been parsed.
Fixes #1476