Proof of Concept: Custom exporter support #1350

dehall · 2023-08-08T14:31:22Z

This is a proof of concept for supporting drop-in custom exporters.

This approach takes advantage of the Java ServiceLoader to load in JARs containing classes that implement a certain interface. I've defined two interfaces here, PatientExporter and PostCompletionExporter. (The existing exporters weren't modified here but they could easily extend these interfaces as well)

A template for building a custom exporter is here: https://github.com/dehall/custom-exporter-template

And an example Postgres loader which loads Patient basic info and Conditions into simple tables: https://github.com/dehall/example-exporter-postgres

(Documentation is limited on those new repos, apologies)

Note this has not yet been tested with the uberJar, but I believe it should be possible to get it working. I suspect instead of java -jar synthea-with-dependencies.jar though you will have to run something along the lines of java -cp synthea-with-dependencies.jar:new-exporter.jar App

sonatype-lift · 2023-08-08T14:31:28Z

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

sonatype-lift · 2023-08-08T14:47:24Z

src/main/java/org/mitre/synthea/engine/Generator.java

@@ -204,6 +204,7 @@ private void init() {
    if (Config.getAsBoolean("exporter.cdw.export")) {
      CDWExporter.getInstance().setKeyStart((stateIndex * 1_000_000) + 1);
    }
+    Exporter.loadCustomExporters();

    this.random = new Random(options.seed);


PREDICTABLE_RANDOM: This random generator (java.util.Random) is predictable

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-08-08T14:47:26Z

src/main/java/org/mitre/synthea/export/PostCompletionExporter.java

+public interface PostCompletionExporter {
+  /**
+   * 
+   * @param generator


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param generator

*

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-08-08T14:47:28Z

src/main/java/org/mitre/synthea/export/PostCompletionExporter.java

+  /**
+   * 
+   * @param generator
+   * @param options


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param options

*

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-08-08T14:47:30Z

src/main/java/org/mitre/synthea/export/PostCompletionExporter.java

+public interface PostCompletionExporter {
+  /**
+   * 
+   * @param generator


MissingSummary: A summary line is required on public/protected Javadocs.

❗❗ 3 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

src/main/java/org/mitre/synthea/export/PatientExporter.java 10

src/main/java/org/mitre/synthea/export/PatientExporter.java 14

src/main/java/org/mitre/synthea/export/PostCompletionExporter.java 10

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-08-08T14:47:32Z

src/main/java/org/mitre/synthea/export/Exporter.java

+  public static void loadCustomExporters() {
+    if (Config.getAsBoolean("exporter.enable_custom_exporters", false)) {
+      patientExporters = new LinkedList<>();
+      postCompletionExporters = new LinkedList<>();


JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.

Suggested change

postCompletionExporters = new LinkedList<>();

postCompletionExporters = new ArrayList<>();

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-08-08T14:47:34Z

src/main/java/org/mitre/synthea/export/Exporter.java

+
+  public static void loadCustomExporters() {
+    if (Config.getAsBoolean("exporter.enable_custom_exporters", false)) {
+      patientExporters = new LinkedList<>();


JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.

Suggested change

patientExporters = new LinkedList<>();

patientExporters = new ArrayList<>();

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-08-08T14:47:36Z

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.¹

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/synthetichealth/synthea/1350.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/synthetichealth/synthea/1350.diff | git apply

Once you're satisfied, commit and push your changes in your project.

You can preview the patch by opening the patch URL in the browser. ↩

custom exporter concept

8b5c3a2

dehall closed this Aug 8, 2023

dehall deleted the custom_exporters branch August 8, 2023 14:31

sonatype-lift bot reviewed Aug 8, 2023

View reviewed changes

dehall mentioned this pull request Aug 11, 2023

WIP: Add support for external X12 exporter #1351

Closed

dehall restored the custom_exporters branch August 17, 2023 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proof of Concept: Custom exporter support #1350

Proof of Concept: Custom exporter support #1350

dehall commented Aug 8, 2023 •

edited

Loading

sonatype-lift bot commented Aug 8, 2023

sonatype-lift bot Aug 8, 2023

sonatype-lift bot Aug 8, 2023

sonatype-lift bot Aug 8, 2023

sonatype-lift bot Aug 8, 2023

sonatype-lift bot Aug 8, 2023

sonatype-lift bot Aug 8, 2023

sonatype-lift bot commented Aug 8, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

	postCompletionExporters = new LinkedList<>();
	postCompletionExporters = new ArrayList<>();

	patientExporters = new LinkedList<>();
	patientExporters = new ArrayList<>();

Proof of Concept: Custom exporter support #1350

Proof of Concept: Custom exporter support #1350

Conversation

dehall commented Aug 8, 2023 • edited Loading

sonatype-lift bot commented Aug 8, 2023

Sonatype Lift is retiring

sonatype-lift bot Aug 8, 2023

Choose a reason for hiding this comment

sonatype-lift bot Aug 8, 2023

Choose a reason for hiding this comment

sonatype-lift bot Aug 8, 2023

Choose a reason for hiding this comment

sonatype-lift bot Aug 8, 2023

Choose a reason for hiding this comment

sonatype-lift bot Aug 8, 2023

Choose a reason for hiding this comment

sonatype-lift bot Aug 8, 2023

Choose a reason for hiding this comment

sonatype-lift bot commented Aug 8, 2023

🛠 Lift Auto-fix

Footnotes

dehall commented Aug 8, 2023 •

edited

Loading