Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removal of arguments #211

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Allow removal of arguments #211

merged 5 commits into from
Dec 11, 2023

Conversation

dstallenberg
Copy link
Contributor

@dstallenberg dstallenberg commented Dec 11, 2023

Next to adding anonymous arguments (even though the function description specified less), it is now possible for arguments to removed (even though the function description specified more).

This is usefull for example when dealing with arguments with default values.

@dstallenberg dstallenberg requested a review from a team as a code owner December 11, 2023 13:14
@coveralls
Copy link
Collaborator

coveralls commented Dec 11, 2023

Pull Request Test Coverage Report for Build 7168535439

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 46.562%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/analysis-javascript/lib/type/resolving/InferenceTypeModelFactory.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/analysis-javascript/lib/type/resolving/InferenceTypeModelFactory.ts 2 22.58%
Totals Coverage Status
Change from base Build 7168472032: -0.07%
Covered Lines: 1540
Relevant Lines: 3057

💛 - Coveralls

@dstallenberg dstallenberg merged commit 3f32471 into main Dec 11, 2023
12 checks passed
@dstallenberg dstallenberg deleted the feat-less-arguments branch December 11, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants