Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented hamburger menu #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Implemented hamburger menu #1

wants to merge 5 commits into from
+137 −13

Conversation

Savvy
Copy link

@Savvy Savvy commented Jun 10, 2019

No description provided.

SebastiaanYN
SebastiaanYN requested changes Jun 11, 2019
View reviewed changes
Copy link
Member

@SebastiaanYN SebastiaanYN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things:

  • There are some indentation issues in the scss style, tabs too many or too few.
  • The animation of the hamburger icon transforming into the X is a bit strange. If you put the transition duration to 3 seconds you can see it's not fluent.

components/Navbar.vue
v-for="item in items"
:key="item.name"
>
<div class="navigation">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason for wrapping the nav element in another div

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastiaanYN SebastiaanYN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Savvy @SebastiaanYN