Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Kotlin unit tests #228

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Kotlin unit tests #228

wants to merge 4 commits into from

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Mar 22, 2024 •
edited
Loading

This PR

  • Adds base suite of unit tests for the Kotlin side
  • Adds GH workflow to run android unit tests

Todo

  • Ensure GH workflow android-unit-tests succeeds and runs on each PR
  • Ensure normal building of Example app still works

@ovitrif
Merge branch 'master' into test/framework
2e4e77d 
# Conflicts:
#	lib/android/src/main/java/com/reactnativeldk/LdkModule.kt
@ovitrif ovitrif force-pushed the test/framework branch 3 times, most recently from 3792b82 to e553604 Compare March 25, 2024 17:46
@ovitrif ovitrif marked this pull request as ready for review March 25, 2024 19:40
@ovitrif ovitrif mentioned this pull request Feb 28, 2024
Open
4 tasks
@ovitrif ovitrif requested a review from Jasonvdb March 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasonvdb Jasonvdb Awaiting requested review from Jasonvdb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ovitrif