Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
cyberb committed Feb 20, 2015
1 parent 89208aa commit 1fe8c66
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions common/src/main/java/org/syncloud/common/upnp/igd/Router.java
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public int getPortMappingsCount() {

private List<PortMapping> getPortMappings() {

ArrayList<PortMapping> mappings = new ArrayList<>();
ArrayList<PortMapping> mappings = new ArrayList<PortMapping>();
long i = 0;
while (i < LIMIT) {

Expand Down Expand Up @@ -111,7 +111,7 @@ private boolean removePortMapping(PortMapping portMapping) {
private <T extends ActionCallback> T sync(UpnpService upnpService, T callback) {
try {
upnpService.getControlPoint().execute(callback).get(timeout, TimeUnit.SECONDS);
} catch (InterruptedException | ExecutionException | TimeoutException e) {
} catch (Exception e) {
logger.error("interrupted: " + e.getMessage());
}
return callback;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@

import java.util.Map;

//TODO: Modeled after org.fourthline.cling.support.igd.callback.GetExternalIP
//TODO: Ideally has to be moved upstream
//TODO: Remover after this is merged https://github.com/4thline/cling/pull/116
public abstract class GetPortMappingEntry extends ActionCallback {

public GetPortMappingEntry(Service service, long index) {
Expand Down

0 comments on commit 1fe8c66

Please sign in to comment.