Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final fixes #221

Merged
merged 6 commits into from
Dec 13, 2016
Merged

Final fixes #221

merged 6 commits into from
Dec 13, 2016

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented Dec 8, 2016

Some final fixes, related to #220.

As far as I know, we will not be resubmitting the paper itself, only pointing out changes in the annotations on the proof. So changes to the paper here are only for posterity, so that the paper here matches the final published version (at least in content). If someone wants, they can also bring in other changes from the proof (mainly, I noticed they changed the spelling section references in the text, and abbreviated US state names in the affiliations).

We way wish to resubmit the supplement, as it has removed line numbers, and section numbers starting with S (the PeerJ staff have changed the references in the paper to use the "Section S1" format in their proof).

@asmeurer
Copy link
Member Author

asmeurer commented Dec 8, 2016

If anyone knows how to fix the references (see #220) please feel free to push changes up here, and I will add annotations to the proof (or if you don't want to push a change, just comment here what it should be).

isuruf-bot pushed a commit to isuruf-bot/sympy-paper that referenced this pull request Dec 8, 2016
isuruf-bot pushed a commit to isuruf-bot/sympy-paper that referenced this pull request Dec 9, 2016
isuruf-bot pushed a commit to isuruf-bot/sympy-paper that referenced this pull request Dec 9, 2016
isuruf-bot pushed a commit to isuruf-bot/sympy-paper that referenced this pull request Dec 12, 2016
@asmeurer asmeurer merged commit 15d7f63 into master Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant