Quick fix for warning on empty useragent whitelist #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick fix for a warning on call to implode() when an empty useragent whitelist is read. Happened on a 2.6.0 site that has just been upgraded from 2.5.3. The warning is: Symphony Warning: implode(): Invalid arguments passed An error occurred in /Users/miguel/Sites/susanwagner/extensions/maintenance_mode/extension.driver.php around line 90
Quick fix for a warning on call to implode() when useragent whitelist is empty. This happens on a site that was upgraded from 2.5.3 to 2.6.0.
Avoid warning on invalid parameters for implode() function when useragent white list is empty. Fixed previous commit according to Nicolas Brassard's suggestions: "Please always add curly braces for any statement. Doing like this is error-prone. I would also check for is_array() and empty() instead of just checking falsiness."
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to 2.6.0, started getting an error when going into preferences pane, a warning such as follows:
Added a check for the user agent list to not be null before doing the implode().