Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbo] Support custom TurboStreamResponse actions #2298

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Turbo/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Add `<twig:Turbo:Stream>` component
- Add `<twig:Turbo:Frame>` component
- Add support for custom actions in `TurboStream` and `TurboStreamResponse`

## 2.21.0

Expand Down
28 changes: 28 additions & 0 deletions src/Turbo/src/Helper/TurboStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,34 @@ public static function refresh(?string $requestId = null): string
return \sprintf('<turbo-stream action="refresh" request-id="%s"></turbo-stream>', htmlspecialchars($requestId));
}

/**
* Custom action and attributes.
*
* Set boolean attributes (e.g., `disabled`) by providing the attribute name as key with `null` as value.
*
* @param array<string, string|int|float|null> $attr
*/
public static function action(string $action, string $target, string $html, array $attr = []): string
{
if (\array_key_exists('action', $attr) || \array_key_exists('targets', $attr)) {
throw new \InvalidArgumentException('The "action" and "targets" attributes are reserved and cannot be used.');
}

$attrString = '';
foreach ($attr as $key => $value) {
$key = htmlspecialchars($key);
if (null === $value) {
$attrString .= \sprintf(' %s', $key);
DRaichev marked this conversation as resolved.
Show resolved Hide resolved
} elseif (\is_int($value) || \is_float($value)) {
$attrString .= \sprintf(' %s="%s"', $key, $value);
} else {
$attrString .= \sprintf(' %s="%s"', $key, htmlspecialchars($value));
}
}

return self::wrap(htmlspecialchars($action), $target, $html, $attrString);
}

private static function wrap(string $action, string $target, string $html, string $attr = ''): string
{
return \sprintf(<<<EOHTML
Expand Down
16 changes: 16 additions & 0 deletions src/Turbo/src/TurboStreamResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,20 @@ public function refresh(?string $requestId = null): static

return $this;
}

/**
* Custom action and attributes.
*
* Set boolean attributes (e.g., `disabled`) by providing the attribute name as key with `null` as value.
*
* @param array<string, string|int|float|null> $attr
*
* @return $this
*/
public function action(string $action, string $target, string $html, array $attr = []): static
{
$this->setContent($this->getContent().TurboStream::action($action, $target, $html, $attr));

return $this;
}
}
28 changes: 28 additions & 0 deletions src/Turbo/tests/Helper/TurboStreamTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,32 @@ public function testRefreshWithId(): void
TurboStream::refresh('a"b')
);
}

public function testCustom(): void
{
$this->assertSame(<<<EOHTML
<turbo-stream action="customAction" targets="some[&quot;selector&quot;]" someAttr="someValue" boolAttr intAttr="0" floatAttr="3.14">
<template><div>content</div></template>
</turbo-stream>
EOHTML,
TurboStream::action('customAction', 'some["selector"]', '<div>content</div>', ['someAttr' => 'someValue', 'boolAttr' => null, 'intAttr' => 0, 'floatAttr' => 3.14])
);
}

/**
* @dataProvider customThrowsExceptionDataProvider
*
* @param array<string, string|int|float|null> $attr
*/
public function testCustomThrowsException(string $action, string $target, string $html, array $attr): void
{
$this->expectException(\InvalidArgumentException::class);
TurboStream::action($action, $target, $html, $attr);
}

public static function customThrowsExceptionDataProvider(): \Generator
{
yield ['customAction', 'some["selector"]', '<div>content</div>', ['action' => 'someAction']];
yield ['customAction', 'some["selector"]', '<div>content</div>', ['targets' => 'someTargets']];
}
}