Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Translate "Add ..." text with remote data setup #2279

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jonasdekeukelaere
Copy link

Q A
Bug fix? yes
New feature? no
Issues Fix #...
License MIT

In #2108 the "Add..." translation has been added. But this only worked for non remote data setups. This PR makes it work for remote data setup too.

Also add translation for Dutch.

@carsonbot carsonbot added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Oct 17, 2024
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks :)

Could you update the Autocomplete's CHANGELOG please?

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Oct 17, 2024
@jonasdekeukelaere
Copy link
Author

Changelog updated

@smnandre
Copy link
Member

Do you know why the tests are failing ?

@jonasdekeukelaere
Copy link
Author

No idea, looks like it is the same like in #2108 (comment)

@smnandre smnandre changed the title Translate "Add ..." text with remote data setup [Autocomplete] Translate "Add ..." text with remote data setup Oct 20, 2024
@kbond
Copy link
Member

kbond commented Oct 21, 2024

Thank you @jonasdekeukelaere.

@kbond kbond merged commit 7803fba into symfony:2.x Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants