Don't store ux_live_component URLs in setTargetPath of the security component #1096
Conversation
| @@ -2154,6 +2154,7 @@ class RequestBuilder { | |||
| const fetchOptions = {}; | |||
| fetchOptions.headers = { | |||
| Accept: 'application/vnd.live-component+html', | |||
| 'X-Requested-With': 'XMLHttpRequest', | |||
There was a problem hiding this comment.
Why the value XMLHttpRequest'?
There was a problem hiding this comment.
Why the value
XMLHttpRequest'?
Set the request like a AJAX request. It's the only way I found so that it does not store it in the setTargetPath
There was a problem hiding this comment.
Yes but setTargetPath look only if the XMLHttpRequest is present but doesn't look at his value at all: https://github.com/symfony/symfony/blob/2bac801f8a4cba02e8ecc840fa7bf512034f860a/src/Symfony/Component/HttpFoundation/Request.php#L1714.
The X-Requested-With is not an official header and I can't find official documentation about it, but it look like you can set the value you want. So we can have something like:
'X-Requested-With': 'symfony-ux-live-component',
What do you think?
There was a problem hiding this comment.
I prefer to keep the one that already exists. This way you don't need to modify any other component.
gbere
changed the title
|
Thanks Gerard! |
Solves issue #1095
Prevent to redirect to ux_live_component URL after login