Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Messenger] Document SSL options for Redis #20094

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[Messenger] Document SSL options for Redis #20094

merged 1 commit into from
Oct 14, 2024

Conversation

tarjei
Copy link
Contributor

@tarjei tarjei commented Aug 5, 2024

The SSL options for Redis were missing from the documentation. This patch tries to fix it.

@xabbuh xabbuh added this to the 6.4 milestone Aug 5, 2024
@carsonbot carsonbot changed the title Document SSL options for Redis [Messenger] Document SSL options for Redis Aug 28, 2024
phansys
phansys reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please, check the CS issues.

messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
messenger.rst Outdated Show resolved Hide resolved
@tarjei
Copy link
Contributor Author

tarjei commented Sep 9, 2024

@phansys thanks! Done :)

phansys
phansys reviewed Sep 9, 2024
View reviewed changes
messenger.rst Outdated Show resolved Hide resolved
phansys
phansys reviewed Sep 9, 2024
View reviewed changes
messenger.rst Outdated Show resolved Hide resolved
@phansys
Copy link
Contributor

phansys commented Sep 9, 2024

IIUC, the support for this option was actually added after this fix, in version 6.4.7.
So, I guess this PR should target (at least) the branch 6.4.

@tarjei
Copy link
Contributor Author

tarjei commented Sep 9, 2024

@phansys should I change the suggested branch for the PR?

@phansys
Copy link
Contributor

phansys commented Sep 9, 2024

@phansys should I change the suggested branch for the PR?

I'd say yes, at least to branch 6.4. Maybe the core members could suggest a previous one.

BTW, if the ssl option is intended to expose the PHP SSL context, I guess we should add a link to the documentation for these options, document the current ones and left a comment that they might change with the time.

@tarjei tarjei changed the base branch from 7.1 to 6.4 September 10, 2024 07:38
@tarjei tarjei changed the base branch from 6.4 to 7.1 September 10, 2024 07:39
@tarjei
Copy link
Contributor Author

tarjei commented Sep 10, 2024

@phansys I tried changing the base, but I'll wait untill @xabbuh or @OskarStark comment on the issue of correct branch.

@xabbuh
Copy link
Member

xabbuh commented Sep 10, 2024

6.4 looks correct to me

@javiereguiluz javiereguiluz changed the base branch from 7.1 to 6.4 October 14, 2024 14:25
@javiereguiluz javiereguiluz force-pushed the redis-messenger-ssl-documentation branch from 743bfc1 to 887e4d3 Compare October 14, 2024 14:25
@javiereguiluz javiereguiluz merged commit 2877e7e into symfony:6.4 Oct 14, 2024
2 of 3 checks passed
@javiereguiluz
Copy link
Member

Merged! (in 6.4 and up). Thanks Tarjei and thanks to reviewers too.

@phansys phansys mentioned this pull request Oct 14, 2024
Merged
javiereguiluz added a commit that referenced this pull request Oct 15, 2024
@javiereguiluz
minor #20325 [Messenger] Add reference to PHP docs for SSL context op…
9ae9efe 
…tions (phansys)

This PR was merged into the 6.4 branch.

Discussion
----------

[Messenger] Add reference to PHP docs for SSL context options

Follows #20094 (comment).

Commits
-------

f39f657 [Messenger] Add reference to PHP docs for SSL context options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@tarjei @phansys @xabbuh @javiereguiluz @OskarStark @carsonbot