-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update some terminology based on AlexJS reports #14215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Nice changes!
@wouterj as you know this kind of PR are "problematic" because they change lots of files, so they introduce lots of conflicts quickly. So, do you think it's ready for merge or do you want to make more changes? If it's ready, do you want to merge this yourself or do you want me to do it? Thanks! |
great work .. I am hoping that one day (sooner rather than later) I can provide a scanner that is better at dealing with context that we can integrate but until then I think it is a great idea to just run such analysis on a regular basis with manual review. |
* 4.4: [#14215] Replace dummy with a better alternative
* 5.1: [#14215] Replace dummy with a better alternative
no worries .. I was slow to react and Javier’s point was very valid about
the risk of conflicts. thanks for the quick follow up commit.
On Sun, 13 Sep 2020 at 12:56, Wouter J ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In bundles.rst
<#14215 (comment)>
:
> @@ -45,9 +45,9 @@ Creating a Bundle
-----------------
This section creates and enables a new bundle to show there are only a few steps required.
-The new bundle is called AcmeTestBundle, where the ``Acme`` portion is just a
-dummy name that should be replaced by some "vendor" name that represents you or
-your organization (e.g. ABCTestBundle for some company named ``ABC``).
+The new bundle is called AcmeTestBundle, where the ``Acme`` portion is a dummy
I merged to quickly. I've fixed this after the merge in 5717ed7
<5717ed7>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14215 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACJJ5Y2NQ73NTWXJZYWVMLSFSQMJANCNFSM4RGAE5FA>
.
--
regards,
Lukas
|
This PR replaces some insensitive/inconsiderate terminology based on AlexJS reports. It's very much subjective, I've not fixed all things AlexJS provided and even AlexJS (while based on official sources) implements some sort of subjective list of words to be considered insensitive/inconsiderate.
99% of the changes in this PR are:
Because sometimes AlexJS reports words that are fine in that context (and AlexJS has some trouble understanding rst syntax), I don't think we can run AlexJS as part of our GitHub actions. I did however commit the
.alexjsrc
file to ease local use. For instance, I'm using Vim with ALE. This asynchronously runs everything I type in*.rst
or*.md
files through Alex; commiting the Alex config makes it easier for me to spot mistakes.cc @lsmith77 @javiereguiluz