[TwigBundle] Enable #[AsTwigFilter], #[AsTwigFunction] and #[AsTwigTest]
#20879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no clue why the CI fails to build the docs, I can build it properly on my end 😞 |
Fan2Shrek
reviewed
Apr 13, 2025
GromNaN
reviewed
Apr 13, 2025
|
Thanks for the comment GromNan, it's very appreciated especially since I'm still new to the doc repository. I'm slowly starting to get the hang of how to write it 🎉. I'll apply your suggestions tomorrow 😄 |
alamirault
approved these changes
Apr 23, 2025
GromNaN
suggested changes
Apr 24, 2025
| @@ -158,30 +158,23 @@ Twig Extension & Autoconfiguration | |||
|
|
|||
| Thanks to Symfony's service handling, you can *extend* Symfony in many ways, like | |||
| by creating an event subscriber or a security voter for complex authorization | |||
| rules. Let's add a new filter to Twig called ``greet``. How? Create a class | |||
| that extends ``AbstractExtension``:: | |||
| rules. Let's add a new filter to Twig called ``greet``. How? Create a simple class | |||
There was a problem hiding this comment.
We avoid subjective words like "simple". "Plain" or nothing would be more adapted.
| @@ -1608,6 +1600,16 @@ If you want to create a function instead of a filter, define the | |||
| Along with custom filters and functions, you can also register | |||
| `global variables`_. | |||
|
|
|||
| .. versionadded:: 7.3 | |||
|
|
|||
| Support for the ``#[AsTwigFilter]`` and ``#[AsTwigFunction]`` attributes was introduced in Symfony 7.3. | |||
There was a problem hiding this comment.
Here you can add the #[AsTwigTest] to the list.
Comment on lines
+1636
to
1640
| When using attributes to extend Twig, the services are initialized only when | ||
| the functions or filters are used to render the template. But in case you use the | ||
| classic approach by extending the ``AbstractExtension`` class, Twig initialize all extensions before | ||
| rendering rendering any template, even if the template doesn't use an | ||
| extension. |
There was a problem hiding this comment.
Suggested change
| When using attributes to extend Twig, the services are initialized only when | |
| the functions or filters are used to render the template. But in case you use the | |
| classic approach by extending the ``AbstractExtension`` class, Twig initialize all extensions before | |
| rendering rendering any template, even if the template doesn't use an | |
| extension. | |
| When using attributes to extend Twig, the services are initialized only when | |
| the functions or filters are used to render the template. But in case you use the | |
| classic approach by extending the ``AbstractExtension`` class, Twig initializes all the extensions before | |
| rendering any template, even if the extension is not used in the template. |
OskarStark
changed the title
#[AsTwigTest]#[AsTwigFilter], #[AsTwigFunction] and #[AsTwigTest]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #20828
I did not listed the
AsTwigTestattribute in the attributes list as no doc make mention of use case of this attribute. Do I had it anyway without any link to it (or a link to the twig documentation)?Also I hope my wording is correct, feel free to ask me any adjustment 😄
I followed the plan of @javiereguiluz