Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipes for eonx-com packages #912
Add recipes for eonx-com packages #912
Changes from all commits
7ef4f43
733425a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these empty interfaces really be in the application? Don't they belong to your package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nyholm Thank you for looking at the PR. The interfaces for roles and permissions are a "convention" we started to use to centralise the definition of roles/permissions in the application and also to allow these roles/permissions to be reused in the code in a consistent way.
The application doesn't have to use it but we recommend doing it this way, that's why we include these empty interfaces as part of the recipe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late to the party, but if you don't force to use this interface, which is fine, it should belong to the code repository and not the recipe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OskarStark it's only been a few years it's ok 😄 Thank you for taking the time to look at it. I actually completely forgot about this PR so your comment reminded me of it, that's good.
We can actually close it, because since then we have migrated all our projects to using PHP for the application config, so these recipes are now irrelevant.
But once again, thanks for looking into it and bringing that back to my attention!