Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixes version of sensiolabs-de/storyblok-bundle #1682

Conversation

silasjoisten
Copy link
Contributor

Copy link

github-actions bot commented Sep 28, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1682/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1682/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'sensiolabs-de/storyblok-bundle:^0.2'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

sensiolabs-de/storyblok-bundle

0.1 vs 0.2
diff --git a/sensiolabs-de/storyblok-bundle/0.1/config/packages/storyblok.yaml b/sensiolabs-de/storyblok-bundle/0.2/config/packages/storyblok.yaml
index e60c7e28..7615ba87 100644
--- a/sensiolabs-de/storyblok-bundle/0.1/config/packages/storyblok.yaml
+++ b/sensiolabs-de/storyblok-bundle/0.2/config/packages/storyblok.yaml
@@ -2,3 +2,4 @@ storyblok:
     base_uri: '%env(STORYBLOK_API_BASE_URI)%'
     token: '%env(STORYBLOK_API_TOKEN)%'
 #   assets_token: '%env(STORYBLOK_ASSETS_API_TOKEN)%'
+#   webhook_secret: '%env(STORYBLOK_WEBHOOK_SECRET)%'
diff --git a/sensiolabs-de/storyblok-bundle/0.2/config/routes/storyblok.yaml b/sensiolabs-de/storyblok-bundle/0.2/config/routes/storyblok.yaml
new file mode 100644
index 00000000..17d9f3c2
--- /dev/null
+++ b/sensiolabs-de/storyblok-bundle/0.2/config/routes/storyblok.yaml
@@ -0,0 +1,2 @@
+storyblok:
+    resource: '@StoryblokBundle/config/routes.php'
diff --git a/sensiolabs-de/storyblok-bundle/0.1/manifest.json b/sensiolabs-de/storyblok-bundle/0.2/manifest.json
index e94bd732..331afda5 100644
--- a/sensiolabs-de/storyblok-bundle/0.1/manifest.json
+++ b/sensiolabs-de/storyblok-bundle/0.2/manifest.json
@@ -8,6 +8,7 @@
     "env": {
         "STORYBLOK_API_BASE_URI": "https://api.storyblok.com",
         "STORYBLOK_API_TOKEN": "",
-        "#1": "STORYBLOK_ASSETS_API_TOKEN="
+        "#1": "STORYBLOK_ASSETS_API_TOKEN=",
+        "#2": "STORYBLOK_WEBHOOK_SECRET="
     }
 }

OskarStark
OskarStark previously approved these changes Sep 28, 2024
auto-merge was automatically disabled September 28, 2024 10:05

Head branch was pushed to by a user without write access

auto-merge was automatically disabled September 28, 2024 10:06

Head branch was pushed to by a user without write access

OskarStark
OskarStark previously approved these changes Sep 28, 2024
@silasjoisten
Copy link
Contributor Author

I release initially the 1.0 version but i figured out thats a bad idea for an yet unstable bundle so i deleted the tags and released 0.1

auto-merge was automatically disabled September 30, 2024 11:40

Head branch was pushed to by a user without write access

auto-merge was automatically disabled September 30, 2024 12:19

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot merged commit 7c5e820 into symfony:main Sep 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants