Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KocalBiomeJsBundle] Add recipe for 1.1, update biome.json from 1.0 aswell #1654

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Aug 6, 2024

Q A
License MIT
Packagist

I've released a new version https://github.com/Kocal/BiomeJsBundle/releases/tag/v1.1.0, which needs some recipe adjustments

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 6, 2024 06:56
Copy link

github-actions bot commented Aug 6, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1654/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1654/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'kocal/biome-js-bundle:^1.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

kocal/biome-js-bundle

1.0 vs 1.1
diff --git a/kocal/biome-js-bundle/1.0/config/packages/kocal_biome_js.yaml b/kocal/biome-js-bundle/1.1/config/packages/kocal_biome_js.yaml
index fe6bb9d6..233a5d8b 100644
--- a/kocal/biome-js-bundle/1.0/config/packages/kocal_biome_js.yaml
+++ b/kocal/biome-js-bundle/1.1/config/packages/kocal_biome_js.yaml
@@ -1,4 +1,7 @@
 when@dev:
     kocal_biome_js:
-        # Explicitly configure the version of Biome.js to use (https://github.com/biomejs/biome/tags), or null to use the latest version
-        binary_version: null
+        # Biome.js CLI version to use:
+        # - "latest_stable": use the latest stable version
+        # - "latest_nightly": use the latest nightly version
+        # - or a specific version, e.g. "v1.8.3", find available tags at https://github.com/biomejs/biome/tags
+        binary_version: 'latest_stable'

auto-merge was automatically disabled August 6, 2024 06:59

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) August 6, 2024 06:59
@symfony-recipes-bot symfony-recipes-bot merged commit 6920ee6 into symfony:main Aug 6, 2024
1 of 2 checks passed
@Kocal Kocal deleted the biomejs-bundle/1.1 branch August 6, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants