Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update recipe for LiipMonitorBundle 3 #1605

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 30, 2024

Q A
License MIT
Packagist

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) March 30, 2024 07:41
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1605/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1605/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'liip/monitor-bundle:^3.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

liip/monitor-bundle

2.6 vs 3.0
diff --git a/liip/monitor-bundle/2.6/config/packages/monitor.yaml b/liip/monitor-bundle/2.6/config/packages/monitor.yaml
deleted file mode 100644
index cc6b6673..00000000
--- a/liip/monitor-bundle/2.6/config/packages/monitor.yaml
+++ /dev/null
@@ -1,3 +0,0 @@
-liip_monitor:
-    # enabling the controller requires that `assets` are enabled in the framework bundle
-    enable_controller: false
diff --git a/liip/monitor-bundle/2.6/manifest.json b/liip/monitor-bundle/3.0/manifest.json
index c9238280..7a10b37b 100644
--- a/liip/monitor-bundle/2.6/manifest.json
+++ b/liip/monitor-bundle/3.0/manifest.json
@@ -1,8 +1,5 @@
 {
     "bundles": {
-        "Liip\\MonitorBundle\\LiipMonitorBundle": ["all"]
-    },
-    "copy-from-recipe": {
-        "config/": "%CONFIG_DIR%/"
+        "Liip\\Monitor\\LiipMonitorBundle": ["all"]
     }
 }

@symfony-recipes-bot symfony-recipes-bot merged commit 511e963 into symfony:main Mar 30, 2024
1 of 2 checks passed
@xabbuh xabbuh deleted the liip-monitor-bundle-3 branch March 30, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants