Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dama/doctrine-test-bundle] Use when@ keyword #1591

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[dama/doctrine-test-bundle] Use when@ keyword #1591

merged 1 commit into from
Feb 13, 2024

Conversation

marcelsiegert
Copy link
Contributor

Q A
License MIT
Packagist https://packagist.org/packages/dama/doctrine-test-bundle

Symfony 5.3 introduced the when@... special key for configuring multiple environments in a single file. DAMADoctrineTestBundle 7.2 was the first version to only support Symfony 5.3 or newer, so it should be safe to create a new recipe for version 7.2.

Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1591/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1591/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'dama/doctrine-test-bundle:^7.2'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

dama/doctrine-test-bundle

4.0 vs 7.2
diff --git a/dama/doctrine-test-bundle/7.2/config/packages/dama_doctrine_test_bundle.yaml b/dama/doctrine-test-bundle/7.2/config/packages/dama_doctrine_test_bundle.yaml
new file mode 100644
index 00000000..3482cbae
--- /dev/null
+++ b/dama/doctrine-test-bundle/7.2/config/packages/dama_doctrine_test_bundle.yaml
@@ -0,0 +1,5 @@
+when@test:
+    dama_doctrine_test:
+        enable_static_connection: true
+        enable_static_meta_data_cache: true
+        enable_static_query_cache: true
diff --git a/dama/doctrine-test-bundle/4.0/config/packages/test/dama_doctrine_test_bundle.yaml b/dama/doctrine-test-bundle/4.0/config/packages/test/dama_doctrine_test_bundle.yaml
deleted file mode 100644
index 80b00911..00000000
--- a/dama/doctrine-test-bundle/4.0/config/packages/test/dama_doctrine_test_bundle.yaml
+++ /dev/null
@@ -1,4 +0,0 @@
-dama_doctrine_test:
-    enable_static_connection: true
-    enable_static_meta_data_cache: true
-    enable_static_query_cache: true

@symfony-recipes-bot symfony-recipes-bot merged commit fcad105 into symfony:main Feb 13, 2024
1 of 2 checks passed
@marcelsiegert marcelsiegert deleted the dama-doctrine-test-bundle-when-at branch February 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants