Add #[NoDiscard] to the PHP 8.5 polyfill #522
Open
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 5, 2025 17:19
Introduce the NoDiscard attribute for marking return values as important, aligning with PHP 8.5's new feature. Updated the autoload configuration to include stubs and documented the addition in the README.
OskarStark
reviewed
Apr 5, 2025
GromNaN
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Thanks, the stub is identical to the one provided in php-src: https://github.com/TimWolla/php-src/blob/d80682e753af13a89ad71ee78100ce44045f175d/Zend/zend_attributes.stub.php#L88-L97
Indeed. I presumed that was the correct thing to do. Do we know when this Polyfill will be published as non-dev. I noticed it's on Packagist, but not as 1.38 (or whatever the other polyfills are). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.