Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/dockerize #1275

Closed
wants to merge 5 commits into from
Closed

Conversation

mehdibo
Copy link

@mehdibo mehdibo commented Nov 27, 2021

I am working on Dockerizing the demo, this is a starter but still need to improve some stuff.

  • Is this supposed to be used for dev? meaning is the code going to change while the container is running?
  • About the frontend part, should it be built when running the containers or just use the pushed build?
  • What's the decision about the database? should I move it to Postgres or leave SQLite?

Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Alexander Kochetov <[email protected]>
@COil
Copy link
Contributor

COil commented Dec 24, 2021

Hello @creocoder, you will find related answers from Javier here : #931 (review)

Is this supposed to be used for dev? meaning is the code going to change while the container is running?

I think yes.

About the frontend part, should it be built when running the containers or just use the pushed build?

Pushed build. But the containers should be able to regenerate the assets IMHO.

What's the decision about the database? should I move it to Postgres or leave SQLite?

Leave SQLite.

@COil
Copy link
Contributor

COil commented Dec 24, 2021

Regarding the other PR, I'm not sure it worths working on this.

@mehdibo
Copy link
Author

mehdibo commented Dec 24, 2021

Hello @COil

Regarding the other PR, I'm not sure it worths working on this.

If you mean no need to work on my PR, that's my understanding after @javiereguiluz explained to me the debate,
If however the community accepts this as a Good enough to Dockerize the demo I'm ready to improve it.

@mehdibo mehdibo closed this Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants