Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os.UserHomeDir for getting user profile directory #19

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Use os.UserHomeDir for getting user profile directory #19

merged 1 commit into from
Apr 15, 2024

Conversation

chrisdeeming
Copy link
Contributor

As suggested in review of #18 by @tucksaun this prefers to use os.UserHomeDir rather than accessing environment variables directly.

tucksaun
tucksaun approved these changes Apr 15, 2024
View reviewed changes
discovery_windows.go Show resolved Hide resolved
@fabpot fabpot merged commit 81cf7b8 into symfony-cli:main Apr 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tucksaun tucksaun tucksaun approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdeeming @tucksaun @fabpot