Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Becca scrutineering review #4

Open
wants to merge 146 commits into
base: empty-for-review
Choose a base branch
from
Open

Becca scrutineering review #4

wants to merge 146 commits into from

Conversation

rebeccamccabe
Copy link

No description provided.

degoeden and others added 30 commits March 26, 2024 12:42
@degoeden @rebeccamccabe
Create README
a986d48
@KapilKhanal @rebeccamccabe
Update README
c39dde5
@KapilKhanal @rebeccamccabe
Update README
70175e1
@degoeden @rebeccamccabe
no pwa
9f92898
@degoeden @rebeccamccabe
Update README
5a406e7
@degoeden @rebeccamccabe
MOOOOOOOOOOO!
de58005
@oliviavitale35 @rebeccamccabe
Create kd_ratio
8b0725b
@degoeden @rebeccamccabe
moved kd_ratio
0908d59
@degoeden @rebeccamccabe
disturbance coefficient integrated
2d82938
@degoeden @rebeccamccabe
sensitivities done
e61b278
@degoeden @rebeccamccabe
corrected parameter comment
4ace172
@degoeden @rebeccamccabe
did i do it?
f678429
@degoeden @rebeccamccabe
vgbjhnm ,
d4562a5
@degoeden @rebeccamccabe
I'm getting rid of this shortly
4f289bd
@degoeden @rebeccamccabe
bjnm,
76228f1
@degoeden @rebeccamccabe
the model works again and doesn't take forever
90965ca
@degoeden @rebeccamccabe
soo
b606797
@degoeden @rebeccamccabe
moo!
ab18bac
@degoeden @rebeccamccabe
I started trying, but I forgot that LCOE is weird
d66f56b
@degoeden @rebeccamccabe
lcoe is still wierd
7102252
@degoeden @rebeccamccabe
I changed LCOE, hopefully for the better
9be7a2b
@degoeden @rebeccamccabe
changed how L is defined
8d55791
@KapilKhanal @rebeccamccabe
TopelitzEngine added and folder to write out the files added
87d42b1
@KapilKhanal @rebeccamccabe
ACA fixed
efca7d1
@KapilKhanal @rebeccamccabe
38k seconds instead of 55k seconds using ACA
68d978e
@KapilKhanal @rebeccamccabe
Pareto curve
e8d390f
@KapilKhanal @rebeccamccabe
Pareto curve remade
c35d4c3
@KapilKhanal @rebeccamccabe
ACA distance changed
ddbdad4
@KapilKhanal @rebeccamccabe
new termination criteria
44c4db4
@KapilKhanal @rebeccamccabe
new termination criteria
09a11fd
degoeden and others added 26 commits March 26, 2024 12:46
@degoeden @rebeccamccabe
pdf pareto
185f478
@degoeden @rebeccamccabe
getting rid of some files
4857336
@degoeden @rebeccamccabe
trying to ignore the __init__ stuff
ffbd59a
@degoeden @rebeccamccabe
now ignoring the __init__ stuff
702d328
@degoeden @rebeccamccabe
Delete src/__init__.py
01d7bf8
@degoeden @rebeccamccabe
Delete src/modules/__init__.py
1b08751
@degoeden @rebeccamccabe
balitsky is now a pdf
0b59fdf
@degoeden @rebeccamccabe
new rand fig
5add90b
@degoeden @rebeccamccabe
bigger font size for the nominal layouts
98b49c0
@oliviavitale35 @rebeccamccabe
updated plotting for kd
66c020b
@degoeden @rebeccamccabe
nominal layout plots, now bold
f3fa074
@degoeden @rebeccamccabe
kd fields
41c07b4
@degoeden @rebeccamccabe
min lcoe and space design plots
6fbbf32
@KapilKhanal @rebeccamccabe
plot
d8d2089
@degoeden @rebeccamccabe
better plots
29db5cc
@KapilKhanal @rebeccamccabe
before scrutineering updattes.
741681c
@KapilKhanal @rebeccamccabe
regression and sensitivity code updated.
3e33baf
@KapilKhanal @rebeccamccabe
changed thee regression to only reegrress optimal lcoe with distance.
6f853a1
@oliviavitale35 @rebeccamccabe
altered q-factor code to change the hydro coeffs and damping for the …
1c50e20 
…single WEC in the loop. also are attempting to calculate RAO but not successful yet
@KapilKhanal @rebeccamccabe
Update README
894238c
@KapilKhanal @rebeccamccabe
Update and rename README to README.md
1e8abf5
@KapilKhanal @rebeccamccabe
Update and rename README.md to README
bb62e7a
@KapilKhanal @rebeccamccabe
Update README
83cfaef
@degoeden @rebeccamccabe
nominal run is good again
8c2a059
@degoeden @rebeccamccabe
renamed the file that was causing Becca issues, needs a real name tho…
491208b 
…ugh, currently wierd_name.csv
@rebeccamccabe
update all files to match main for review, since the rebase didnt ful…
591475e 
…ly work
rebeccamccabe
rebeccamccabe commented Mar 26, 2024
View reviewed changes
README
@@ -0,0 +1,53 @@
Multi-Objective Multidisciplinary Optimization of Wave Energy Converter Array Layout and Controls
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this a markdown file (.md) instead of plain text for readability. Add other information (ie funding acknowledgement) - see https://confluence.cornell.edu/display/sealab/Publishing+Code

src/post_pro/kd_field.py Show resolved Hide resolved
src/modules/distances.py Show resolved Hide resolved
@rebeccamccabe
Copy link
Author

now the only difference between this branch and main are some csv files in data/paretos which I am not going to worry about

rebeccamccabe
rebeccamccabe commented Mar 29, 2024
View reviewed changes
environment.yml Show resolved Hide resolved
environment.yml Show resolved Hide resolved
src/main_moo_opt.py Show resolved Hide resolved
src/modules/dynamics_controls.py Show resolved Hide resolved
src/modules/econ.py Show resolved Hide resolved
src/post_pro/pareto_analysis.py Show resolved Hide resolved
src/post_pro/qfactor.py Show resolved Hide resolved
src/post_pro/sensitivity.py Show resolved Hide resolved
src/post_pro/waveField.py Show resolved Hide resolved
src/qfactor.out Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@degoeden degoeden degoeden left review comments

@oliviavitale35 oliviavitale35 oliviavitale35 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rebeccamccabe @degoeden @oliviavitale35 @KapilKhanal