Helm Chart #46
Merged
Helm Chart #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tri-adam
force-pushed
the
helm-chart
branch
15 times, most recently
from
00c7118 to
120aaa5
Compare
SylabsJess
reviewed
Feb 25, 2020
| echo http://$SERVICE_IP:{{ .Values.service.port }} | ||
| {{- else if contains "ClusterIP" .Values.service.type }} | ||
| export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "fuzzball.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}") | ||
| echo "Visit http://127.0.0.1:8080 to use your application" |
There was a problem hiding this comment.
I see service.port in values.yaml however this is hard-coded
There was a problem hiding this comment.
I think this is OK, as its just referencing the first port in the kubectl port-forward command.
| {{- else if contains "ClusterIP" .Values.service.type }} | ||
| export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "fuzzball.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}") | ||
| echo "Visit http://127.0.0.1:8080 to use your application" | ||
| kubectl --namespace {{ .Release.Namespace }} port-forward $POD_NAME 8080:80 |
There was a problem hiding this comment.
I see service.port in values.yaml however this is hard-coded
There was a problem hiding this comment.
Good point. And actually, I don't know why I'm using the pod here and not the service... will switch!
added 8 commits
February 25, 2020 17:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial Helm chart.
It is possible to test using Docker Desktop. First, build a
servercontainer locally. This needs to be tagged withappVersion, which is currently set to0.1.0:docker build -t server:0.1.0 -f build/docker/server/Dockerfile .Next, fetch deps with
helm:Then run the install. In my environment, setting
image.pullPolicy=Neveris enough for Docker Desktop to pull the image built above:A minute or so later, you should have six pods running:
At the moment, the service is not functional, as I haven't yet wired up the services to the
serverbinary, which you can see from the logs:I will fix this once #47 is implemented.