Remove the thirdparty.zip malarkey. Potentially significant performance win, #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
win, significant decrease in complexity of maintaining the app, at a cost of bumping the number of files to be uploaded from just over 200 to just over 300.
|
Exact numbers: the Current master branch: After this patch: The limit is 3k files. We have a long way to go before the zip functionality helps us in any way at all. |
|
After talking to other people yesterday, it seems as though the performance gain here is probably not as significant as I had thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
significant decrease in complexity of maintaining the app, at a
cost of bumping the number of files to be uploaded from just over 200 to
just over 300.
If we ever need this back, it's in the git history and we can pull it back out.