Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sanitization to lib-param-bn #12

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Move sanitization to lib-param-bn #12

merged 1 commit into from
Dec 18, 2023

Conversation

daemontus
Copy link
Member

@daemontus daemontus commented Oct 18, 2023

New version of lib-param-bn and lib-bdd support a generalized sanitization process at the level of individual Bdd and BddVariableSet objects (it also supports a wider range of use cases, although it still won't reorder variables). Hence we no longer need the sanitization code directly in the model checker.

The process is tested in the original libraries, but I haven't added specific tests here, I just rely on the existing tests. If some extra testing should be added to verify everything is working as intended, please let me know.

Also, we don't necessarily need to merge this anytime soon, but it's nice to remove the duplicate functionality.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5dc65a5) 89.40% compared to head (e56995b) 89.14%.

❗ Current head e56995b differs from pull request most recent head 8d8f148. Consider uploading reports for the commit 8d8f148 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   89.40%   89.14%   -0.27%     
==========================================
  Files          24       24              
  Lines         812      792      -20     
==========================================
- Hits          726      706      -20     
  Misses         86       86              
Files Coverage Δ
src/postprocessing/sanitizing.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daemontus daemontus merged commit 34eebcb into master Dec 18, 2023
11 of 12 checks passed
@daemontus daemontus deleted the update-lib-param-bn branch December 18, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant