Replaced setNick by useNick #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var originalNick = core.nickname; | ||
| this.send('nick', tmpNick); | ||
| core.nickname = tmpNick; | ||
| task(); |
There was a problem hiding this comment.
This only supports synchronous tasks.
|
If you want to support async tasks, you're going to have to implement a P.S. please run grunt, I can already see some places where the style checker will complain :P |
|
I reinstated the setNick command, then. I'm not expecting either of these commands to get much use, even less in async, but here you go. I've also changed a few line to matc the code style and documented useNick(), as per alxgnon's request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the setNick('NewName') function by useNick('newName", function) to ensure that the received nick is only kept for the duration of the task it needs to do.