feat(assets): link color variables of SVG illustrations #3610
Conversation
…ions_Max-Makaluk' of https://github.com/FussuChalice/organized-app into CU-86c0wjqg8_FEAT-Link-color-variables-of-SVG-illustrations_Max-Makaluk
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request updates two components. The first change updates the import and usage of the unsupported browser illustration by switching from an image URL import to a component import, and renders it within a styled wrapper. The second change reverses the conditional rendering logic in the RootLayout: the UnsupportedBrowser component is now rendered when the application is supported, while the main content (including components such as Contact, About, and others) is rendered when not supported. These modifications adjust the control flow and component usage without altering overall structure. Changes
Sequence Diagram(s)sequenceDiagram
participant RL as RootLayout
participant UBC as UnsupportedBrowser
participant MC as MainContent
RL->>RL: Check isSupported
alt isSupported true
RL->>UBC: Render UnsupportedBrowser component
else isSupported false
RL->>MC: Render main content components (Contact, About, Support, etc.)
RL->>MC: Render Suspense fallback
end
Suggested Reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…G-illustrations_Max-Makaluk
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
src/assets/img/general-error-illustration.svgis excluded by!**/*.svg,!**/*.svgsrc/assets/img/illustration_no_assigments.svgis excluded by!**/*.svg,!**/*.svgsrc/assets/img/illustration_no_persons.svgis excluded by!**/*.svg,!**/*.svgsrc/assets/img/illustration_no_search_results.svgis excluded by!**/*.svg,!**/*.svgsrc/assets/img/permission-error-illustration.svgis excluded by!**/*.svg,!**/*.svgsrc/assets/img/unsupported-browser-illustration.svgis excluded by!**/*.svg,!**/*.svg
📒 Files selected for processing (2)
src/features/app_start/shared/unsupported_browser/index.tsx(2 hunks)src/layouts/root_layout/index.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (2)
src/features/app_start/shared/unsupported_browser/index.tsx (2)
9-9: LGTM! Import change aligns with PR objective.The change from
?urlto?componentimport enables proper handling of SVG color variables.
41-43: LGTM! Proper component usage with sizing constraints.The Box wrapper with width and height constraints ensures proper scaling of the SVG illustration.
|
organized-app
|
||||||||||||||||||||||||||||
| Project |
organized-app
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 11s |
| Commit |
|
| Committer | Max Makaluk |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
| View all changes introduced in this branch ↗︎ | |
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
I used SVG Tokenizer - a figma plugin to export with variables. Here on Github the colors in SVG are not displayed.
Type of change
Checklist: