Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoadingButton support #255

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add LoadingButton support #255

wants to merge 10 commits into from

Conversation

BierDav
Copy link
Contributor

@BierDav BierDav commented Aug 21, 2023

I've added another package @suid/lab, even though i've fixed the known issues on mui it's unstable too, so I tried to match that.
Maybe this requires also an update of codemod when using react2solid, but i don't have an idea what and where to change so i hope for a follow up commit after merging that updates that.

Documentation is also added for the new component. I've already tested the component with ssr, so it should also work with ssr.

This PR includes my other PR, because i needed everything in one branch so that i cloud start using my code locally.

The extraction method in the extractMaterialSource.ts script has been replaced from 7z to tar. This change has been made to improve the compatibility of the script as tar is more universally supported across various systems as compared to 7z. Now, the source code extraction will occur without issues regardless of the system's architecture.
Make Checkbox value deprecated to avoid unwanted use
Add documentation for LoadingButton
@BierDav
Copy link
Contributor Author

BierDav commented Sep 29, 2023

Please merge

Copy link

@Felix0014 Felix0014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM

@BierDav
Copy link
Contributor Author

BierDav commented Oct 10, 2023

@juanrgm Please

@BierDav
Copy link
Contributor Author

BierDav commented Oct 16, 2023

Hello?

@juanrgm
Copy link
Member

juanrgm commented Oct 16, 2023

I greatly appreciate the work you've done, but I'm reluctant to incorporate experimental packages into the project or ones outside of @mui/material.

SUID requires constant effort and incorporating experimental packages can hinder the evolution of the project.

I know that the component is simple and surely there will be no problem, but going outside of @mui/material opens the door for other users to request more components from @mui/lab, @mui/joy and @mui /x-* and would mean a total overflow of work, something that no project maintainer could assume.

I hope you understand and share my position, in any case I am open to suggestions.

@BierDav
Copy link
Contributor Author

BierDav commented Oct 16, 2023

Hmmm, i see your point. But what if we just make clear that @mui/lab is not officially maintained? I would love to see a compromise, because as a developer, I just want to use the library and don't always have to worry about missing features. And i think there are a lot of people who would love to use this component. The problem is really that we need it to be in a npm package. And the last thing i want to do is creating my own fork and publishing it to confuse all other people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants