-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LoadingButton
support
#255
base: main
Are you sure you want to change the base?
Conversation
The extraction method in the extractMaterialSource.ts script has been replaced from 7z to tar. This change has been made to improve the compatibility of the script as tar is more universally supported across various systems as compared to 7z. Now, the source code extraction will occur without issues regardless of the system's architecture.
Make Checkbox value deprecated to avoid unwanted use Add documentation for LoadingButton
This reverts commit 9193259.
This reverts commit d7b2c0b.
Please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGM
@juanrgm Please |
Hello? |
I greatly appreciate the work you've done, but I'm reluctant to incorporate experimental packages into the project or ones outside of SUID requires constant effort and incorporating experimental packages can hinder the evolution of the project. I know that the component is simple and surely there will be no problem, but going outside of I hope you understand and share my position, in any case I am open to suggestions. |
Hmmm, i see your point. But what if we just make clear that |
I've added another package
@suid/lab
, even though i've fixed the known issues on mui it's unstable too, so I tried to match that.Maybe this requires also an update of
codemod
when usingreact2solid
, but i don't have an idea what and where to change so i hope for a follow up commit after merging that updates that.Documentation is also added for the new component. I've already tested the component with ssr, so it should also work with ssr.
This PR includes my other PR, because i needed everything in one branch so that i cloud start using my code locally.