feat(components): create post-list component #3812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss-to-attribute-in-stencil-config
…drated attribute selector in snapshot e2e tests
…drated instead of the hydrated class
…y use the attribute data-hydrated instead of the hydrated class
…nstead of the hydrated class
…napshots`, so they use the attribute data-hydrated instead of the hydrated class
…ss-to-attribute-in-stencil-config
🦋 Changeset detectedLatest commit: 00f1c2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
myrta2302
changed the title
Co-authored-by: Alizé Debray <[email protected]>
…em.tsx Co-authored-by: Alizé Debray <[email protected]>
Co-authored-by: Alizé Debray <[email protected]>
…ot.stories.ts Co-authored-by: Alizé Debray <[email protected]>
…s.ts Co-authored-by: Alizé Debray <[email protected]>
…s.ts Co-authored-by: Alizé Debray <[email protected]>
myrta2302
force-pushed
the
3544-component-list
branch
from
bd0bf11
to
e8b9e27
Compare
alizedebray
requested changes
Nov 1, 2024
packages/documentation/src/stories/components/list/list.docs.mdx
Outdated
Show resolved
Hide resolved
packages/documentation/src/stories/components/list/list.stories.ts
Outdated
Show resolved
Hide resolved
|
alizedebray
approved these changes
Nov 5, 2024
Comment on lines
+18
to
+19
| ## `<post-list>` | ||
|
|
There was a problem hiding this comment.
Suggested change
| ## `<post-list>` |
Comment on lines
+41
to
+53
| render: args => | ||
| html`<post-list | ||
| title-hidden="${args.titleHidden ? args.titleHidden : nothing}" | ||
| horizontal="${args.horizontal ? args.horizontal : nothing}" | ||
| style="${args.listTitleGap !== null | ||
| ? `--post-list-title-gap: ${args.listTitleGap}rem;` | ||
| : ''}${args.listItemGap !== null ? ` --post-list-item-gap: ${args.listItemGap}rem` : ''}" | ||
| > | ||
| <h3>Title</h3> | ||
| <post-list-item>List Item 1</post-list-item> | ||
| <post-list-item>List Item 2</post-list-item> | ||
| <post-list-item>List Item 3</post-list-item> | ||
| </post-list> `, |
There was a problem hiding this comment.
Suggested change
| render: args => | |
| html`<post-list | |
| title-hidden="${args.titleHidden ? args.titleHidden : nothing}" | |
| horizontal="${args.horizontal ? args.horizontal : nothing}" | |
| style="${args.listTitleGap !== null | |
| ? `--post-list-title-gap: ${args.listTitleGap}rem;` | |
| : ''}${args.listItemGap !== null ? ` --post-list-item-gap: ${args.listItemGap}rem` : ''}" | |
| > | |
| <h3>Title</h3> | |
| <post-list-item>List Item 1</post-list-item> | |
| <post-list-item>List Item 2</post-list-item> | |
| <post-list-item>List Item 3</post-list-item> | |
| </post-list> `, | |
| render: args => { | |
| let styles; | |
| if (args.listTitleGap) styles += `--post-list-title-gap: ${args.listTitleGap};`; | |
| if (args.listItemGap) styles += `--post-list-item-gap: ${args.listItemGap};`; | |
| return html`<post-list | |
| title-hidden="${args.titleHidden ? args.titleHidden : nothing}" | |
| horizontal="${args.horizontal ? args.horizontal : nothing}" | |
| style="${styles ? styles : nothing}" | |
| > | |
| <h3>Title</h3> | |
| <post-list-item>List Item 1</post-list-item> | |
| <post-list-item>List Item 2</post-list-item> | |
| <post-list-item>List Item 3</post-list-item> | |
| </post-list> `; | |
| }, |
| listItemGap: { | ||
| name: '--post-list-item-gap', | ||
| description: 'Defines the gap between list items.', | ||
| control: { type: 'number', min: 0, max: 10, step: 1 }, |
There was a problem hiding this comment.
Suggested change
| control: { type: 'number', min: 0, max: 10, step: 1 }, | |
| control: { type: 'text' }, |
| listTitleGap: { | ||
| name: '--post-list-title-gap', | ||
| description: 'Defines the gap between the title and the list items.', | ||
| control: { type: 'number', min: 0, max: 10, step: 1 }, |
There was a problem hiding this comment.
Suggested change
| control: { type: 'number', min: 0, max: 10, step: 1 }, | |
| control: { type: 'text' }, |
| /** | ||
| * The unique title of the list that is also referenced in the labelledby | ||
| */ | ||
| @State() uuid: string; |
There was a problem hiding this comment.
Suggested change
| @State() uuid: string; | |
| @State() titleId: string; |
| /** | ||
| * Get the id set on the host element or use a random id by default | ||
| */ | ||
| this.uuid = `list-${crypto.randomUUID()}`; |
There was a problem hiding this comment.
Suggested change
| this.uuid = `list-${crypto.randomUUID()}`; | |
| this.titleId= `list-title-${crypto.randomUUID()}`; |
| <Host data-version={version}> | ||
| <div | ||
| ref={el => (this.titleEl = el)} | ||
| id={this.uuid} |
There was a problem hiding this comment.
Suggested change
| id={this.uuid} | |
| id={this.titleId} |
| > | ||
| <slot></slot> | ||
| </div> | ||
| <div role="list" aria-labelledby={this.uuid}> |
There was a problem hiding this comment.
Suggested change
| <div role="list" aria-labelledby={this.uuid}> | |
| <div role="list" aria-labelledby={this.titleId}> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.