feat(documentation): Add pseudo-class to snapshots with storybook-addon-pseudo-states plugin #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imagoiq
requested review from
b1aserlu,
davidritter-dotcom and
a team
as code owners
|
imagoiq
commented
Oct 16, 2023
Comment on lines
-13
to
+55
| const combinations = [ | ||
| ...COMBINATIONS, | ||
| { | ||
| label: `Label - no Placeholder`, | ||
| placeholder: null, | ||
| }, | ||
| { | ||
| label: `Label - with Value`, | ||
| value: 'Lorem Ipsum', | ||
| }, | ||
| ]; | ||
| return html` | ||
| <div class="d-flex flex-wrap align-items-start gap-regular"> | ||
| ${['bg-white', 'bg-dark'].map( | ||
| bg => html` | ||
| <div class="${bg} d-flex gap-3 flex-column p-3"> | ||
| <h3>Sizes</h3> | ||
| ${getCombinations('size', context.argTypes.size.options, combinations) | ||
| .filter( | ||
| (args: Args) => | ||
| !args.value || | ||
| (args.value && | ||
| (context.args.type === 'text' || context.args.type === 'password')), | ||
| ) | ||
| .map( | ||
| (args: Args) => | ||
| html` | ||
| <div> | ||
| ${args.title !== undefined && args.title | ||
| ? html` | ||
| <h4> | ||
| ${Object.entries(context.argTypes.size.control.labels) | ||
| .filter(([key, value]) => key === args.size) | ||
| .map(s => s[1])} | ||
| </h4> | ||
| ` | ||
| : ''} | ||
| <div>${meta.render?.({ ...context.args, ...args }, context)}</div> | ||
| </div> | ||
| `, | ||
| )} | ||
| ${context.argTypes.size.options.map((size: string) => { | ||
| const variants = bombArgs({ | ||
| combinations: COMBINATIONS, | ||
| size: [size], | ||
| pseudoClass: ['null', 'focus'], | ||
| }) | ||
| .map(extractCombinationsArgs) | ||
| .filter( | ||
| (args: Args) => | ||
| !args.value || | ||
| (args.value && | ||
| (context.args.type === 'text' || context.args.type === 'password')), | ||
| ) | ||
| .map(args => renderVariant(args, context)); | ||
|
|
||
| return html` | ||
| <section> | ||
| <h4>${context.argTypes.size.control.labels[size]}</h4> | ||
| <div class="d-flex gap-3 flex-column">${variants}</div> | ||
| </section> | ||
| `; | ||
| })} | ||
| <h3>Floating Label</h3> | ||
| ${getCombinations('floatingLabel', [true], combinations) | ||
| ${bombArgs({ | ||
| combinations: COMBINATIONS, | ||
| floatingLabel: [true], | ||
| pseudoClass: ['null', 'focus'], | ||
| }) | ||
| .map(extractCombinationsArgs) | ||
| .filter( | ||
| (args: Args) => | ||
| !args.value || | ||
| (args.value && | ||
| (context.args.type === 'text' || context.args.type === 'password')), | ||
| ) | ||
| .map( | ||
| (args: Args) => | ||
| html` | ||
| <div>${meta.render?.({ ...context.args, ...args }, context)}</div> | ||
| `, | ||
| )} | ||
| .map(args => renderVariant(args, context))} |
There was a problem hiding this comment.
I refactored this part to use bombArgs instead of a custom function. So #2001 will be easier.
|
Preview environment ready: https://preview-2076--swisspost-design-system-next.netlify.app |
|
Kudos, SonarCloud Quality Gate passed!
|
imagoiq
added
the
on hold
imagoiq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use
storybook-addon-pseudo-statesplugin to simulate pseudo-class likehover,focus, etc. This plugin rewrite the associated stylesheet and try to replace the defined pseudo-class with a class using the following naming template.pseudo-${pseudoClassName}.Limitation
@media (prefers-reduced-motion: no-preference)usage.::-moz-range-thumbor::-webkit-slider-thumb. This can be fixed by adding them here: https://github.com/chromaui/storybook-addon-pseudo-states/blob/07abc1bb39ee4f3377955b23860c275de12b872f/src/constants.js#L6Misc