review comments update

swisspost · Nov 5, 2024 · ca4bd5d · ca4bd5d
1 parent f4d2f10
commit ca4bd5d
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 39 deletions.
diff --git a/packages/styles/index.html b/packages/styles/index.html
@@ -29,40 +29,47 @@ <h1>Styles package playground</h1>
       <option value="internal">Post internal</option>
     </select>
     <hr />
-    <!-- Place your component markup here -->
-    <blockquote class="blockquote" lang="de">
-      <q
-        >Lorem ipsum dolor sit amet <q>consectetur adipiscing elit</q>. Integer posuere erat a ante.
-        Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer posuere erat a ante.</q
-      >
 
+    <!-- Place your component markup here -->
+    <figure>
+      <blockquote class="blockquote" lang="de">
+        <q
+          >Lorem ipsum dolor sit amet <q>consectetur adipiscing elit</q>. Integer posuere erat a
+          ante. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer posuere erat a
+          ante.</q
+        >
+      </blockquote>
       <figcaption class="blockquote-footer">
         Author
         <cite>Source</cite>
       </figcaption>
-    </blockquote>
+    </figure>
 
-    <blockquote class="blockquote" lang="en">
-      <q
-        >Lorem ipsum dolor sit amet <q>consectetur adipiscing elit</q>. Integer posuere erat a ante.
-        Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer posuere erat a ante.</q
-      >
+    <figure>
+      <blockquote class="blockquote" lang="en">
+        <q
+          >Lorem ipsum dolor sit amet <q>consectetur adipiscing elit</q>. Integer posuere erat a
+          ante. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer posuere erat a
+          ante.</q
+        >
+      </blockquote>
       <figcaption class="blockquote-footer">
         Author
         <cite>Source</cite>
       </figcaption>
-    </blockquote>
-
-    <blockquote class="blockquote" lang="fr">
-      <q
-        >Lorem ipsum dolor sit amet <q>consectetur adipiscing elit</q>. Integer posuere erat a ante.
-        Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer posuere erat a ante.</q
-      >
-
+    </figure>
+    <figure>
+      <blockquote class="blockquote" lang="fr">
+        <q
+          >Lorem ipsum dolor sit amet <q>consectetur adipiscing elit</q>. Integer posuere erat a
+          ante. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer posuere erat a
+          ante.</q
+        >
+      </blockquote>
       <figcaption class="blockquote-footer">
         Author
         <cite>Source</cite>
       </figcaption>
-    </blockquote>
+    </figure>
   </body>
 </html>
diff --git a/packages/styles/src/components/blockquote.scss b/packages/styles/src/components/blockquote.scss
@@ -1,6 +1,5 @@
 @use '../tokens/components';
 @use '../functions/tokens';
-@use './../placeholders/blockquote' as blockquote-ph;
 
 tokens.$default-map: components.$post-quote;
 
@@ -28,7 +27,6 @@ figure:has(.blockquote) {
   }
 }
 
-.blockquote-footer {
-  @extend %body;
+figcaption .blockquote-footer {
   margin-top: tokens.get('post-quote-gap-inline');
 }
diff --git a/packages/styles/src/placeholders/_blockquote.scss b/packages/styles/src/placeholders/_blockquote.scss