-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yahoo Search Added #887
base: develop
Are you sure you want to change the base?
Yahoo Search Added #887
Conversation
Hi @Harshil0512 thank you for this! I am going to check and see if the serpapi package is desireable or if we would prefer to do these using RequestsGet. Thank you |
Yaa sure @sidprobstein Please let me know, if required then I'll change it but I think this should work as it is giving us the desired response |
Hello @sidprobstein are you there ? |
Hello @sidprobstein Please reply to me, I'm ready with another search provider but unable to create another PR due to this PR is not merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Harshil0512 ,
Thank you for the contribution! Please make the following adjustments to the PR...
- Do not add the SearchProvider JSON to
SearchProviders/preloaded.json
file - Retarget the
yahoosearch.json
file to land in theSearchProviders/untested
directory - Add the
CosineRelevancyResultProcessor
last to the list ofquery_processors
(and you might need theMappingResultProcessor
as well, if you're going to useresult_mappings
below) - Try to add some
response_mappings
values from the API response (see here) - Pleae add some proper
result_mappings
to the SearchProvider JSON file (see here) - Retarget the
yahoosearch.py
file to land in theswirl/connectors/untested
directory - Remove the changes to
settings.py
andmodels.py
from the PR
Also, I'm curious about the GoogleSearch import in line 12 of your connector file...why is that there? @sid-swirl should likely review the connector code in more detail though.
If you can make the above updates as a start, that would be great.
Thanks!
Thank you so much @erikspears for your reply, I performed the changes you've suggested to me can you please have a look into it. GoogleSearch import in line 12 of your connector file
for more info you can visit https://serpapi.com/yahoo-search-api |
Implemented Yahoo Search
To utilize this functionality, follow these steps:
Get the Serpapi API Key:
If not, refer to https://serpapi.com/yahoo-search-api
Add API Key to Swirl Configuration:
Insert API Key into your Swirl configuration file.
Restart Swirl:
Restart Swirl to apply the changes.
Now, you can start searching for Yahoo Search content.
Related Issue(s)
Associated issue https://github.com/swirlai/swirl-search/issues/789
Type of Change