added discord connector #783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horw
reviewed
Oct 20, 2023
horw
reviewed
Oct 20, 2023
sid-swirl
reviewed
Oct 20, 2023
sid-swirl
reviewed
Oct 20, 2023
sid-swirl
requested changes
Oct 20, 2023
There was a problem hiding this comment.
@SubramanyamChalla24 this looks awesome you have made a lot of progress; please review the comments I added to the "files changed" and can discuss on Slack. It's very close!
horw
reviewed
Oct 21, 2023
|
Hi, I've added a connector for Qdrant as mentioned in the issue #721 . |
sidprobstein
requested changes
Oct 26, 2023
sidprobstein
approved these changes
Oct 27, 2023
Closed
|
@SubramanyamChalla24 please make one final change:
Omit changes to init.py for now. Thank you! I will merge immediately once these changes are made. |
|
what is the status now, qdrant and discord? pending over a month now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branching
Always branch off from the
developbranch with a descriptive name that encapsulates your idea or fix. This practice helps ensure that ourmainbranch remains stable.Description
Added the discord connector
Related Issue(s)
#689
Testing and Validation
Tested this only on local system as the discord connector doesn't seem show up in the admin dashboard when using docker. Would require a test from others and verify.
Screenshots (if appropriate):
Documentation
Changes Include
PR Checklist
developbranch of the swirl-search repo.