Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to indicate swimUSD & do not mark them as stable coin #438

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

swimthor
Copy link
Contributor

Notion ticket: https://www.notion.so/exsphere/Mark-swimUSD-as-not-a-stablecoin-and-override-in-UI-ed8a5fc9e6c84083af460264023dd64a

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@swimthor swimthor requested a review from wormat October 13, 2022 19:39
@swimthor swimthor self-assigned this Oct 13, 2022
@swimthor swimthor force-pushed the swim-usd-is-not-stable-coin branch from c19821e to e1eed2e Compare October 13, 2022 19:39
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 13, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e1eed2e
Status: ✅  Deploy successful!
Preview URL: https://8a661be6.swim-ui.pages.dev
Branch Preview URL: https://swim-usd-is-not-stable-coin.swim-ui.pages.dev

View logs

Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a fan of this. Why not just compare against the token project ID?

@swimthor
Copy link
Contributor Author

@wormat because we also have swimUSDv2, it will be bulky to use if we have to check the token project id

@wormat
Copy link
Collaborator

wormat commented Oct 13, 2022

Ah but we won't have legacy token projects in the SDK after https://www.notion.so/exsphere/Remove-any-kind-of-legacy-support-from-the-SDK-e2bb36ec76164d2e98de8a270296e9d8
I'm OK with adding it to the UI config I guess, or having a helper function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants