Fix Optional implementation for ConstructibleFromJSValue #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Optional.construct
returnsnil
when the given JS value isnull
orundefined, but
nilmeans a failure during decode here, so it's semantically wrong. Instead, it should return
.some(nil)`.Also, when
Wrapped.construct
returnsnil
, it means decode operation failed, soOptional.construct
method should returnnil
. But it might be unclear that the returnedOptional<Wrapped>
value won't be implicitly casted to.some(nil)
, so I changed to returnnil
byguard
statement explicitly.Original description
現在の実装ではJSの値として
null
,undefined
の場合に、Optional.construct
がnil
を返していますが、これはデコードの失敗を意味するため間違っています。
適切に
Optional.none
がデコードできた状況なので、.some(nil)
を返す必要があります。また、
Wrapped.construct
がnil
を返した場合は、デコード失敗なので
nil
を返すべきですが、ここで暗黙のキャストによって
.some(nil)
が返ってしまうかどうか分かりづらいと思ったので、明示的に guard 文で分岐するように書き換えてみました。